Issue when Adding a Subtask if the dependencies exist

[SIM-LTD]

Hi,

To reproduce the issue simply run the basic demo (https://www.bryntum.com/examples/gantt/basic/)
Then follow the step herewith (look at the screenshot) :

1) Add 3 Tasks (using the contextual Menu "Add below")
2) Create dependencies on each Task
3) Then, Click on the First Task, then from the Contextual Menu Add SubTask.

You'll see first that the new subtask (or Summary Task) is added BUT with the dependencies of the first Task.
The First Task has lost its Dependency.

Then you'll notice that the whole Gantt is corrupted. Meaning that from the Gantt Chart the Summary Tasks (SubTask) has only one Child When from the Grid he has 3 Children

But what is more critical is :
if you Drag the Task second Task from the Grid to reorder the sequence (WBS) the issue "Graph Cycle Detected" is thrown out.

[saki]

Dependencies seem OK to me, but I could trigger the exception.

https://youtu.be/69HE7hiC-aw

Ticket is here:

https://app.assembla.com/spaces/bryntum/tickets/9274-gantt--dragging-created-task-from-grid-can-trigger-exception/details

[SIM-LTD]

Hi

Thank you for your report and Video.
Sorry to insist a bit.

Your video explains and shows perfectly how the description of the Issue :

1) When the SubTak is Added (or Summary Task) we can see clearly that the dependency belonging to the Task is removed and attached to the SubTask.... This should not occur??

2) When you Drag the first task from the Grid then crash occurs....

So the question is why did say

Dependencies seem OK to me

.
When you can see clearly that the Task has lost its dependency and that dependency has been linked to the newly subtask?
The SubTask is supposed to be acting as a Parent Task and when added, should not have any dependency, and should not remove the dependency of the children, that was selected to add the subTask.

Hence there are 2 issues, not only one regarding "Drag" from the Grid...

[saki]

I'll try to explain why dependencies look good to me:

Here we can see dependencies from task 1 to task 2 to task 3 so all correct now.

Screen Shot 2019-09-20 at 11.41.37.png (43.62 KiB) Viewed 1914 times

Here task 4 was added as a subtask of task 1. Dependency from task 1 to task 2 is retained. Task 1 becomes a "summary" task with one child task 4.

Screen Shot 2019-09-20 at 11.41.03.png (57.17 KiB) Viewed 1914 times

Dependencies from "summary" tasks are valid so all seems fine to me.

Note: Screenshots were taken from the video (time 0:23 and time 0:29) therefore the low quality.

[SIM-LTD]

Hi,

We went through the overall processes and realized that when clicking onto a Task (basic one) then the option "Add a subTask" leads to:

1) Convert the basic Task into "Summary Task / or Parent Task"
2) Add a sub Task (Child Task) under the newly Parent.

We believe this is a terrible error from you having taken such path, to add a "Summary or Parent" Task.

Let's explain why :

If the current Task is having a couple of constraints (earlyStartDate / effort /Dependencies/lag/successor/predecessor/ etc.....), then you'll transfer all these constraints to the newly created Parent; and then create a new task with empty properties.
That means, once the Task is converted to a Parent then the overall Gantt is completely changed, moreover if you add some extra task into this newly parent.

Why did you simply add an option "Add New Summary or Parent" and let the user Dagging any task from the Grid inside that new Parent?
This would be much easier and less complicated than converting a Task to a SubTask and Add a new task!!
Because look at the screenshot herewith. When you click on a Milestone and you select the option "add SubStask"
the system adds the Parent Task with the style of the milestone!! Which does not make sense at all!!

In Real Gantt, a "Summary Task" does not have the look of the Milestone and vis-versa!
Adding a SubTask in a Milestone does not make sense (see the screenshot)

We're sorry to say that the way you have implemented "Adding a Parent" via the option "Add Subtask" is wrong because by principal all Task cannot be converted to Parent. The screenshot shows how your way can be absurd.

For us the main issue is whenever you click right and select the option "Add SubTask" you convert the selected task (no matter what it is!!!) in Summary Task (Parent). Moreover you keep the style!! which is getting funny when it comes to run the "Add SubStask" on a Milestone This is an issue we have already reported at the very beginning... (look at the screenshot)

As we said adding an option "Add Parent Below" or "Add Paren Above" or simply "Add Summary" would have been much easier and less complicated. Look at our screenshot.

For now, the option "Add Subtask" does not fit our needs at all and can make the mess in the existing Gantt.

We'll remove that option "Add SubTask" from the context menu and create our own one "Add Summary".
Let us know if you do the same one day.

[saki]

Thank you very much for your thoughts; they are a very valuable input for us.

[saki]

There is one feature that is coming in the next minor release of Bryntum Gantt and that is "indent". It could provides a good way of putting existing tasks to a new parent: create the to-be-parent above and then indent them.

We have already had it in Ext Gantt, so you can see it in action here: https://www.bryntum.com/examples/gantt-for-extjs/advanced/#en

[SIM-LTD]

Hi Saki

Very nice feature. We're looking forward to testing that.

As you have given us the same news in the previous post (viewtopic.php?f=52&t=12256)
then the answer is the same.

Thank you very much for your support