BryntumGrid - extend React.PureComponent?

Our blazing fast Grid component built with pure javascript
Post Reply
User avatar
Les
Posts: 1
Joined: Sun Nov 25, 2018 11:10 pm

BryntumGrid - extend React.PureComponent?

Post by Les » Sun Nov 25, 2018 11:15 pm

I'm looking at the BryntumGrid class definition.

https://www.bryntum.com/examples/grid/r ... s/grid.jsx

Would the BryntumGrid component be more efficient if the React.PureComponent were extended instead of React.Component?

Here's a usage example:

https://www.bryntum.com/examples/grid/react/app.jsx

User avatar
johan.isaksson
Core Developer
Core Developer
Posts: 160
Joined: Tue Apr 12, 2016 9:50 pm

Re: BryntumGrid - extend React.PureComponent?

Post by johan.isaksson » Mon Nov 26, 2018 9:06 am

Hi,

I am not sure it would have any big impact, but it is worth investigating either that or implementing `shouldComponentUpdate()` to prevent any unnecessary re-renders. Will keep it in mind when doing the next update of the react component.

In the meanwhile, feel free to try it out yourself and please report your findings if you do
Best regards,
Johan Isaksson

Post Reply