SyncRowHeight - #7417

Discuss issues related to v5.x
User avatar
bee
Posts: 9
Joined: Mon Oct 09, 2017 3:29 pm

SyncRowHeight - #7417

Post by bee »

Hi there,
we have also trouble with the issue described in the ticket #7417

Despite the sideeffekt of the vertical scroll effect we are also facing an other issue turning syncRowHeight on.
Deleting and adding events we are getting an Error in "syncRowHeightBegin":

Code: Select all

Uncaught TypeError: Cannot read property 'down' of null
    at ctor.add (ext-all.js:20)
    at ctor.constructor (ext-all.js:20)
    at new ctor (ext-all.js:20)
    at ctor.syncRowHeightBegin (ext-all.js:20)
    at ctor.beginLayout (ext-all.js:20)
    at ctor.resetLayout (ext-all.js:20)
    at ctor.invalidate (ext-all.js:20)
    at ctor.invalidate (ext-all.js:20)
    at ctor.invalidate (ext-all.js:20)
    at ctor.flushInvalidates (ext-all.js:20)
Which leads to a broken Scheduler-View.
Currently we are using the v. 5.1.16 of the Scheduler and v6.5.3.57 of ExtJs.

Are there any news on when the bugfix will be implemented? Will the bugfix also be implemented for v5 or is the version no longer supported for bugfixes of that kind?

Greetings
Eike

User avatar
mats
Core Developer
Core Developer
Posts: 16148
Joined: Sat Dec 19, 2009 11:41 pm
Location: Sweden
Contact:

Re: SyncRowHeight - #7417

Post by mats »

Please try upgrading to our latest version + Ext 6.7 and see if you can still reproduce it?
Tired of debugging javascript errors in web applications? Try our new error logging service RootCause, or read more on the Sencha blog

@bryntum
Facebook
API documentation

User avatar
bee
Posts: 9
Joined: Mon Oct 09, 2017 3:29 pm

Re: SyncRowHeight - #7417

Post by bee »

Because the bug is mentioned in
viewtopic.php?f=39&t=10452
and
viewtopic.php?f=49&t=10274
(latest post was from july) and has still the status "open", i thought the sideeffect still exists?

Because of the breaking changes and other possible incompatibilities i was trying to avoid the hassle of doing an major-version update. Especially if the bug still exists.

User avatar
mats
Core Developer
Core Developer
Posts: 16148
Joined: Sat Dec 19, 2009 11:41 pm
Location: Sweden
Contact:

Re: SyncRowHeight - #7417

Post by mats »

Fixed in our sources, coming out in the next patch release!
Tired of debugging javascript errors in web applications? Try our new error logging service RootCause, or read more on the Sencha blog

@bryntum
Facebook
API documentation

User avatar
mats
Core Developer
Core Developer
Posts: 16148
Joined: Sat Dec 19, 2009 11:41 pm
Location: Sweden
Contact:

Re: SyncRowHeight - #7417

Post by mats »

To get this working on the 5.x branch, 'Sch.view.TimelineGridView' needs this override:

Code: Select all

patchBufferedRenderingPlugin : function (plugin) {
        var me            = this,
            oldSetBodyTop = plugin.setBodyTop;
        // <debug>
        if (typeof oldSetBodyTop !== 'function') {
            throw new Error('oldSetBodyTop method missing');
        }
        // </debug>
        // @OVERRIDE Overriding buffered renderer plugin
        plugin.setBodyTop = function (bodyTop, skipStretchView) {
            var rows = this.view.all;

            // BufferedRenderer#setBodyTop needs to do this.
            // Being at the end of the dataset means we MUST stretch the
            // scroll range. Otherwise we can't get to the end.
            if (rows.endIndex === me.store.getCount() - 1) {
                skipStretchView = false;
            }

            var returnValue = oldSetBodyTop.call(this, bodyTop, skipStretchView);

            me.fireEvent('bufferedrefresh', this);

            return returnValue;
        };
    },
Tired of debugging javascript errors in web applications? Try our new error logging service RootCause, or read more on the Sencha blog

@bryntum
Facebook
API documentation

User avatar
bee
Posts: 9
Joined: Mon Oct 09, 2017 3:29 pm

Re: SyncRowHeight - #7417

Post by bee »

Thanks for your help and reply
Using the mentioned override fixed the error, thanks.

The vertical scrollbar still resets. If i understand you correctly, this will be fixed with the upcoming patch. Will the fix/patch also be available for version 5.xx?

User avatar
mats
Core Developer
Core Developer
Posts: 16148
Joined: Sat Dec 19, 2009 11:41 pm
Location: Sweden
Contact:

Re: SyncRowHeight - #7417

Post by mats »

You should not use syncRowHeight now. Works fine then?
Tired of debugging javascript errors in web applications? Try our new error logging service RootCause, or read more on the Sencha blog

@bryntum
Facebook
API documentation

User avatar
bee
Posts: 9
Joined: Mon Oct 09, 2017 3:29 pm

Re: SyncRowHeight - #7417

Post by bee »

Ah, ok!
Thought both are necessary.

Yes, now everything works perfectly. Thanks!

User avatar
bee
Posts: 9
Joined: Mon Oct 09, 2017 3:29 pm

Re: SyncRowHeight - #7417

Post by bee »

Sorry to bother again,

the fix causes some strange behaviour working with the scheduler.
Adding/Removing events and scrolling afterwards can lead to an incorrect view.
Screenshot: https://ibb.co/VDqRmNs

Also the "Sch.plugin.CurrentTimeLine" randomly disappers/appears during scrolling

User avatar
mats
Core Developer
Core Developer
Posts: 16148
Joined: Sat Dec 19, 2009 11:41 pm
Location: Sweden
Contact:

Re: SyncRowHeight - #7417

Post by mats »

Try using our latest version? I cannot reproduce any odd behavior there
Tired of debugging javascript errors in web applications? Try our new error logging service RootCause, or read more on the Sencha blog

@bryntum
Facebook
API documentation

Post Reply